VW MLB: Add warning before 6min HCA lockout and opportunistic reset during low torque - #3706
Open
oscarmcnulty wants to merge 3 commits into
Open
VW MLB: Add warning before 6min HCA lockout and opportunistic reset during low torque#3706oscarmcnulty wants to merge 3 commits into
oscarmcnulty wants to merge 3 commits into
Conversation
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 130 segments for: VOLKSWAGEN_ARTEON_MK1, VOLKSWAGEN_ATLAS_MK1, VOLKSWAGEN_CRAFTER_MK2, VOLKSWAGEN_GOLF_MK7, VOLKSWAGEN_JETTA_MK7, VOLKSWAGEN_PASSAT_MK8, VOLKSWAGEN_PASSAT_NMS, VOLKSWAGEN_POLO_MK6, VOLKSWAGEN_TAOS_MK1, VOLKSWAGEN_TIGUAN_MK2, VOLKSWAGEN_TOURAN_MK2, VOLKSWAGEN_TRANSPORTER_T61, VOLKSWAGEN_TROC_MK1 ✅ 0 changed, 130 passed, 0 errors |
oscarmcnulty
force-pushed
the
vw-mlb-lateral-nodep
branch
from
August 24, 2026 06:26
b7ff7f0 to
7f7871e
Compare
oscarmcnulty
force-pushed
the
vw-mlb-lateral-nodep
branch
from
September 2, 2026 04:47
4007fd4 to
a0cd14b
Compare
oscarmcnulty
marked this pull request as ready for review
September 2, 2026 04:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLB steering racks have a 6min max engagement. After that time it will return status = 'rejected' for ~2.0s and not execute torque requests. Upon observing that openpilot drops HCA_01 status to 'ready' and after a ~2.0s lockout period the EPS switches from rejected to ready and openpilot immediately applies torque again. This max engagement timer can also be reset by disabling control for ~1.1s at any point before 6 mins.
In the current MLB lateral implementation there are no mitigations for this so every 6 mins of engaged time there will be a temporary fault for ~2.0s without any advanced warning that stops lateral control requiring driver to take immediate control.
This PR adds 2 mitigations to make this safer and less annoying:
Openpilot will require changes similar to this to support the new warning type oscarmcnulty/openpilot@d709ca9
Test route: 35258b7bb90057ff/00000003--676e449e6e (4.5 hours drive showing ~59 opportunistic resets and 0 lockouts at 6 mins)
Test route 35258b7bb90057ff/00000005--22d16cde7f (opportunistic reset disabled to show pre-lockout warning alert)